Skip to content

Conversation

@Zhanbingli
Copy link

I added defensive checks for the input object in set() and onSelect callbacks. While this specific race condition is hard to reproduce locally, this change directly addresses the undefined error reported in #7528 by ensuring setText is only called on a valid object.

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@itsrainingmani
Copy link
Contributor

Unfortunately, this somewhat breaks message forking since the prompt text from the forked message doesn't populate in the input box anymore

@Leka74
Copy link
Contributor

Leka74 commented Jan 10, 2026

this one makes more sense to fix the issue: #7702

@Zhanbingli
Copy link
Author

Unfortunately, this somewhat breaks message forking since the prompt text from the forked message doesn't populate in the input box anymore

Oh! Thank you! This feedback helps me think about how to improve the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants