feat: Implement MCP server instruction fetching and integration #7334
+343
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
seuros
force-pushed
the
instruction
branch
2 times, most recently
from
67e6dd6 to
1a95b75
Compare
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
1 task
seuros
force-pushed
the
instruction
branch
3 times, most recently
from
3c77f7d to
d2dc000
Compare
- Add automatic instruction fetching via client.getInstructions() - Cache server instructions during initialization - Include instructions in LLM system prompts - Remove fetchInstructions config (now automatic) - Add graceful error handling
Resolve conflicts: - mcp/index.ts: Keep both InstructionsChanged and BrowserOpenFailed events - llm.ts: Combine MCP instructions fetching with Codex session handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the LLM can see the instructions that that the server emit at initialisation.
The data was where, just not used.
Fixes #7373