-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: add PWA support and mobile UI improvements #7258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
8e14998 to
1f1089e
Compare
70a44b5 to
e016d06
Compare
e016d06 to
67cc211
Compare
d72695d to
0da9180
Compare
e359812 to
085ad3d
Compare
|
Great work on this PWA support PR, this is really valuable! ✨ |
22c516f to
a18e38b
Compare
|
Thanks for the suggestion! I've added Web Push notification support in the latest commit:
This allows notifications to be delivered even when the PWA is closed. |
PWA Support: - Service worker with intelligent caching (stale-while-revalidate for HTML) - Web app manifest for installable PWA experience - iOS meta tags and safe area inset support Mobile UI: - Virtual keyboard detection for proper layout adjustments - Responsive layout improvements - Mobile-friendly server URL detection for remote access Web Push Notifications: - Push event handler in service worker - Notification click handler to focus/open app - Server endpoints for push subscription management - Auto-subscribe when notification permission granted
a18e38b to
7556808
Compare
Resolved conflict in prompt-input.tsx by combining mobile-friendly styling with new provider icons and model variant selector features.
|
Haha thanks for the quick implementation! Looks awesome! |
- Add SyncGate to wait for data before rendering child components - Fix defensive checks for SolidJS store proxy arrays - Add missing /agent and /find proxy routes for Vite dev server - Use same origin for remote dev access to leverage Vite proxy
- Add scroll-to-bottom button that appears when user scrolls up - Fix toast notification centering on mobile (center on mobile, right on desktop) - Make archive button always visible on mobile (left of status indicator) - Make project menu button always visible on mobile - Add move up/down options in project dropdown for mobile reordering - Extract directory search utilities for better testability - Add swipe gesture utility for future mobile interactions - Add comprehensive test coverage for all mobile features
- Restore notAtBottom tracking in auto-scroll hook for scroll button visibility - Restore question tool registration and CSS in message-part - Restore iOS Safari clipboard fallback for mobile copy - Restore overflow-x: hidden in session-turn to prevent side scroll - Fix scroll button to use notAtBottom() instead of userScrolled() - Reduce mobile padding in prompt-input for better model name display - Add 178 regression tests covering all restored features
The question tool UI was restored but the handlers to actually respond to or reject questions were not connected to the DataProvider.
…ctivity The question tool needs sessionID and callID during the 'running' state to look up pending requests. Previously these were only available in metadata after tool completion, making the question tool non-interactive. - Add sessionID and callID to ToolProps interface - Pass message.sessionID and part.callID to Dynamic component - Update question tool to use props directly instead of metadata - Add comprehensive tests for question tool features
Summary
Features
Related Issues
Demo
Before
trim.3D3639B6-5A06-4CEC-A581-2E71E71D836D.MOV
After
trim.DC05A0D8-1C92-40CB-8646-1D8C25C2CC2D.MOV