Skip to content

fix: rm dead code and add back permission hook #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rekram1-node wants to merge 2 commits into from
Closed

fix: rm dead code and add back permission hook #7253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc6039
fix: rm dead code and add back permission hook
rekram1-node Jan 7, 2026
4af389a
fix: use dynamic import for Plugin to avoid circular dependency
rekram1-node Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 0 additions & 210 deletions packages/opencode/src/permission/index.ts
View file
Open in desktop

This file was deleted.

27 changes: 23 additions & 4 deletions packages/opencode/src/permission/next.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,30 @@ export namespace PermissionNext {
throw new DeniedError(ruleset.filter((r) => Wildcard.match(request.permission, r.permission)))
if (rule.action === "ask") {
const id = input.id ?? Identifier.ascending("permission")
return new Promise<void>((resolve, reject) => {
const info: Request = {
const info: Request = {
id,
...request,
}
const { Plugin } = await import("@/plugin")
const hook = await Plugin.trigger(
"permission.ask",
{
id,
...request,
}
type: request.permission,
pattern: request.patterns,
sessionID: request.sessionID,
messageID: request.tool?.messageID ?? "",
callID: request.tool?.callID,
title: request.permission,
metadata: request.metadata,
time: { created: Date.now() },
},
{ status: "ask" as "ask" | "deny" | "allow" },
).catch(() => ({ status: "ask" as const }))
if (hook.status === "deny")
throw new DeniedError(ruleset.filter((r) => Wildcard.match(request.permission, r.permission)))
if (hook.status === "allow") continue
return new Promise<void>((resolve, reject) => {
s.pending[id] = {
info,
resolve,
Expand Down
Loading