Repository navigation
fix(site): drop the free button from the companions shelf - #62489
Merged
Merged
Conversation
There was a problem hiding this comment.
Looks good. On the site's dev server, the product pages (/desktop, /mobile, /de/desktop) still render every companion row, now without the Free button that the base renders. Nothing still refers to the removed string or the companion get slot; the remaining data-slot="get" belongs to the product list. The i18n and CSS tests pass and tsc is clean.
The public API is unchanged: this is markup, styles and translation strings only.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes the "Free" button from the "Works great with OpenCode" shelf on the product pages. each row keeps its icon, name link and category. drops the
site.companions.freestring and stamps from every locale and the button styles. checked tiles, outline, outline compact and list at desktop, tablet and phone widths.no flag: copy/styling fix.