Repository navigation
feat(site): add a hero to the browse page - #62487
Merged
Merged
Conversation
There was a problem hiding this comment.
Looks good. I ran the site's dev server on this branch:
/product/browsenow server-renders the themed still, with light and dark AVIF and WebP sources frommedia/heroes, theprefers-color-schemepreloads and the theme script./desktopstill renders its video hero. Moving the markup intoproduct-hero.tsxreads as a straight extraction, and makingsrcoptional inHeroVideois handled correctly.
The site's media, manifest, browse and preload tests pass, and tsc --noEmit in services/site is clean.
Public API: unchanged. This is only a marketing page and its static assets.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Browse page (
/product/browse) had a plain black hero. It now has a still in the same style as the other product heroes: OpenCode in the terminal driving an agent tab in an "Agent · localhost" tab group, on the usual flat backdrop (#1e1e1edark,#161616light).product-hero.tsx: the hero markup, poster preload, theme script andHeroVideomoved out ofproduct-page.tsxso both pages share them.srcis optional now, so a poster-only hero works. The/desktophero renders the same markup as before (diffed after hydration).extension-data.tsgetshero: trueon browse, andextension-page.tsxrendersProductHerowithheroStills()fromvideos.ts.public/product-videos/heroes/browse-landscape-{dark,light}.webp(1920×1200), with AVIF and WebP copies at 1280 and 1920 inpublic/media/heroeslisted inmedia-manifest.jsonandmedia-sources.json. No video, so nothing goes to the files bucket.The scene is HTML rendered with Playwright. Tab group names, the RUN badge colour and the MCP tool names match browse and OpenCode. Sites in it are made up.
No flag: it's a static image on a marketing page.
Visual