Repository navigation
fix(site): keep the companions shelf's category in its column on phones - #62486
Merged
Merged
Conversation
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
The fix looks right. The category <span> matched the site-wide block rule [data-component="block"] [data-slot="body"] in site.css (grid-column: 2 / -1, flex column) because the shelf sits inside a block. Renaming the slot to category takes it out of that rule. Nothing else in the site's CSS targets [data-slot="category"]. I checked this by reading the code. I couldn't render the phone layout here, so before/after phone screenshots would help confirm it.
Public API: unchanged (site CSS and markup only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the shelf's category used
data-slot="body", which the surrounding block lays out as its own column (grid-column: 2 / -1, flex), so in the production css order the category ran under the Free button on phones. renamed it tocategory.