Repository navigation
fix(site): order products desktop, terminal, mobile - #62462
Merged
Merged
Conversation
There was a problem hiding this comment.
The change works as described and I found nothing that needs fixing. On the commit it branched from, the server-rendered /product grid showed desktop, mobile, terminal, SDK; with this change it shows desktop, terminal, mobile, SDK. With a phone user agent it still leads with mobile (mobile, desktop, terminal, SDK), so the rewritten deviceOrder keeps the same phone behaviour. The site's translation check (bun src/i18n/check.ts) gives the same results as on pr/base, so the updated stamps match the new English. The site tests (192) pass and tsc --noEmit is clean.
Public API: unchanged. Only site copy, ordering and site-internal data are touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
products are now ordered desktop, terminal, mobile, then SDK everywhere on the site.
productsdata inproduct-data.ts; the home carousel,/productgrid, footer, search and llms follow from itsettings-defaults.jsonproductsOrderproduct-videosmanifest key orderdeviceOrdernow moves mobile to the front instead of swapping it with desktop)Visual
no flag, copy and order change only.