Skip to content

fix(site): remove the home page faq - #62461

Merged
thdxr merged 1 commit into
devfrom
site-no-faq
Nov 7, 2026
Merged

thdxr merged 1 commit into
devfrom
site-no-faq

Conversation

@thdxr

@thdxr thdxr commented Nov 7, 2026

Copy link
Copy Markdown
Member

removes the faq section from the home page: the section, its json-ld FAQPage, its order entry and width setting, its search entries, its markdown version and its design mode copy.

the product pages' download section still shows the same faq (lib/faq-content.ts, home.faq.* strings), so that data and its i18n strings stay.

@thdxr
thdxr merged commit 9a7479d into dev Nov 7, 2026
12 checks passed
@thdxr
thdxr deleted the site-no-faq branch November 7, 2026 01:10

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, and I found nothing blocking. I compared the home page HTML and /index.md from the site's dev server on the merge base and on this branch. The FAQ section, its FAQPage JSON-LD and the markdown ## FAQ are gone, and the product pages' download FAQ still renders. Design-mode orders saved with "faq" still load, because normalizeHomeOrder drops unknown ids. typecheck:tsc and bun test in services/site pass.

Public API: unchanged. These are website-only changes, and faqColumns is an internal Design-mode setting.

One follow-up worth considering: site search now has no FAQ entries at all, including for the FAQ that stays on the product pages. That leaves the target.faq handling in search-palette.tsx and the site.search.faq strings unused. Either point the FAQ entries at a product page's #download or remove that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant