Skip to content

ci(process-daemon): read the release protocol version from the source - #62006

Merged
jlongster merged 1 commit into
devfrom
ci-derive-pty-protocol
Nov 5, 2026
Merged

jlongster merged 1 commit into
devfrom
ci-derive-pty-protocol

Conversation

@jlongster

@jlongster jlongster commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

release-process-daemon.yml hardcoded PROTOCOL_VERSION: 7. The daemon is on protocol 8 now (#61875), so the release's --version checks would fail, and the manifest and release notes would say 7.

Instead of bumping the number (and needing a workflow change on every protocol bump), the checks job reads PROTOCOL_VERSION from packages/process-daemon/src/protocol.rs and exposes it as a job output; build, build-windows and release set PROTOCOL_VERSION from it, so every existing use keeps working unchanged. release now also lists checks in needs so it can read the output.

Needed before tagging the 0.5.0 release (#62007).

How did you verify your code works?

Ran the sed extraction against src/protocol.rs (prints 8) and checked the workflow still parses as YAML. The release jobs themselves only run on a tag or manual dispatch.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@jlongster
jlongster requested a review from a team November 5, 2026 07:10
@jlongster jlongster mentioned this pull request Nov 5, 2026
3 of 6 tasks

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sound to me. The sed extraction returns 8 from src/protocol.rs (the job's default working-directory is packages/process-daemon, so the relative path resolves). All four uses of $PROTOCOL_VERSION are in build, build-windows and release, and each now gets the value from the checks output. release also has checks in needs. With test -n, the run fails early if the constant's format ever changes, so an empty version can't slip through. I couldn't run the release jobs end to end, since they only run on a tag or manual dispatch.

Public API: unchanged (CI workflow only).

@thdxr thdxr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlongster
jlongster merged commit a316ae6 into dev Nov 5, 2026
28 checks passed
@jlongster
jlongster deleted the ci-derive-pty-protocol branch November 5, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants