Repository navigation
ci(process-daemon): read the release protocol version from the source - #62006
Merged
Merged
Conversation
3 of 6 tasks
There was a problem hiding this comment.
The change looks sound to me. The sed extraction returns 8 from src/protocol.rs (the job's default working-directory is packages/process-daemon, so the relative path resolves). All four uses of $PROTOCOL_VERSION are in build, build-windows and release, and each now gets the value from the checks output. release also has checks in needs. With test -n, the run fails early if the constant's format ever changes, so an empty version can't slip through. I couldn't run the release jobs end to end, since they only run on a tag or manual dispatch.
Public API: unchanged (CI workflow only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
release-process-daemon.ymlhardcodedPROTOCOL_VERSION: 7. The daemon is on protocol 8 now (#61875), so the release's--versionchecks would fail, and the manifest and release notes would say 7.Instead of bumping the number (and needing a workflow change on every protocol bump), the
checksjob readsPROTOCOL_VERSIONfrompackages/process-daemon/src/protocol.rsand exposes it as a job output;build,build-windowsandreleasesetPROTOCOL_VERSIONfrom it, so every existing use keeps working unchanged.releasenow also listschecksinneedsso it can read the output.Needed before tagging the 0.5.0 release (#62007).
How did you verify your code works?
Ran the
sedextraction againstsrc/protocol.rs(prints8) and checked the workflow still parses as YAML. The release jobs themselves only run on a tag or manual dispatch.Checklist