fix: use assistant turn boundaries for overflow compaction replay point#20247
Open
jphpeete wants to merge 1 commit intoanomalyco:devfrom
Open
fix: use assistant turn boundaries for overflow compaction replay point#20247jphpeete wants to merge 1 commit intoanomalyco:devfrom
jphpeete wants to merge 1 commit intoanomalyco:devfrom
Conversation
The overflow compaction replay-point search only considered user messages when deciding where to split the conversation for summarization. In sessions where the user interacts primarily through tool responses (e.g. the question tool), user messages are rare and the backward walk would skip over all assistant turns, producing an incomplete summary. Add an assistant-turn boundary check before the user-message check. When a finished assistant message is found, its parent user message is used as the replay point and the summary includes all messages up to and including that assistant turn. Fixes anomalyco#20246
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20246
Related: #19319
Type of change
What does this PR do?
The overflow compaction replay-point search walks backward looking for
role === "user"messages to decide where to split the conversation for summarization. In sessions where the user interacts through tool responses (e.g. the question tool), user messages are rare — the search skips all assistant turns and lands on the first user message, somessages.slice(0, i)produces an empty or tiny array and the summary only covers the start of the session.This adds a check for finished assistant turns before the existing user-message check. When a finished assistant is found first, its parent user message becomes the replay point and the summary includes everything up to that assistant turn. The user-message check remains as a fallback for normal conversations.
This is a targeted fix for compaction; #19319 tracks the broader issue of synthetic user messages being treated as real user history.
How did you verify your code works?
bun typecheck— cleanbun test test/session/compaction.test.ts— 38 pass (2 new), 0 failScreenshots / recordings
Not a UI change.
Checklist