fix: normalize windows path separators in session queries#20216
Open
tcflying wants to merge 2 commits intoanomalyco:devfrom
Open
fix: normalize windows path separators in session queries#20216tcflying wants to merge 2 commits intoanomalyco:devfrom
tcflying wants to merge 2 commits intoanomalyco:devfrom
Conversation
Fixes Windows session list display issues where sessions become invisible due to path separator inconsistencies. Changes: - Add normalizePathSeparators() function to filesystem utilities - Normalize paths in session.createNext() when storing sessions - Normalize paths in Session.list() when querying by directory - Normalize paths in Session.listGlobal() when querying by directory - Normalize paths in Project.discover() when updating session project IDs This resolves GitHub Issues anomalyco#16744 and anomalyco#18029 where sessions created with backslash paths would not be visible when querying with forward slash paths, or vice versa. Related to PR anomalyco#17067 by HRronaldo Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Also normalize Windows drive letters to uppercase for consistent path matching. This ensures paths like 'c:/path' and 'C:/path' are treated the same.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
The current PR (20216) and PR #20215 have identical titles and appear to address the same issue. You should verify whether one of these is a duplicate or if they have different implementations. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16744
Closes #18029
Type of change
What does this PR do?
This PR fixes the Windows session list display issue where newly created sessions become invisible due to path separator inconsistencies. When sessions are created with backslash paths on Windows but queried with forward slash paths, the database strict string matching would fail to find them.
The root cause is that Windows paths can use either backslashes or forward slashes, and the drive letter can be lowercase (c:/) vs uppercase (C:/).
Changes made:
This ensures all path comparisons use consistent format regardless of Windows path formatting.
How did you verify your code works?
Checklist