Asyncio migration #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is our attempt to move to concurrency before the library goes out of hand there are a few exception at the moment around typer not being able to support async/await we can work around that when they support it #18
moved to explicitly closing the client upon each requestREFS #18
pending running a full test this changes all the test calls to be async, we recomend merging this branch into the dto-implementation branch and let the tests run against the server to see if the tests pass REFS #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Majority implementation of the following issues
asynciobefore the library gets too large #18pytest-asyncioTo be reviewed later:
pytestinitialisation be made into async, may be not necessary?Note that merging this will run a full set of tests in async mode