Skip to content

fix: making a copy list of componentsBuffer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noiverree wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: making a copy list of componentsBuffer #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b2b41b
fix: making a copy list of componentsBuffer
noiverree Nov 23, 2024
2887867
fix: syntax error
noiverree Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Assets/uPools/Runtime/Internal/PoolCallbackHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ internal static class PoolCallbackHelper
public static void InvokeOnRent(GameObject obj)
{
obj.GetComponentsInChildren(componentsBuffer);
foreach (var receiver in componentsBuffer)
var componentsToInvoke = new List<IPoolCallbackReceiver>(componentsBuffer);

foreach (var receiver in componentsToInvoke)
{
receiver.OnRent();
}
Expand All @@ -19,10 +21,12 @@ public static void InvokeOnRent(GameObject obj)
public static void InvokeOnReturn(GameObject obj)
{
obj.GetComponentsInChildren(componentsBuffer);
foreach (var receiver in componentsBuffer)
var componentsToInvoke = new List<IPoolCallbackReceiver>(componentsBuffer);

foreach (var receiver in componentsToInvoke)
{
receiver.OnReturn();
}
}
}
}
}