Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Moving Constants To Separate File #252

Closed
wants to merge 1 commit into from

Conversation

SIMRAN1
Copy link
Contributor

@SIMRAN1 SIMRAN1 commented Apr 20, 2018

Description

According to swift Standard Guidelines Constants should be declared in separate file.

Fixes #222

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

All the required Constants are moved to Separate File and tested in Simulator.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@SIMRAN1 SIMRAN1 closed this Apr 20, 2018
@SIMRAN1 SIMRAN1 reopened this Apr 20, 2018
@anitab-org anitab-org deleted a comment Apr 20, 2018
@anitab-org anitab-org deleted a comment Apr 20, 2018
@anitab-org anitab-org deleted a comment Apr 20, 2018
@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Apr 20, 2018

@sunjunkie mam Please review the above changes. If above changes looks good then I can add more Constants in File.

@sunjunkie sunjunkie closed this Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Strings.swift to group strings in enums and update accessors throughout the app.
2 participants