Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

coredata added for database and only used in homepage #157

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

paraschhugani
Copy link

Description

I have added Coredata and only used in the home screen showing the Name of user,

Fixes Issue #146

Type of Change:

Not deleted any code, added entity and attributes for database.

103199853-df074780-4911-11eb-84f5-54b184396227.mov

Code/Quality Assurance Only

  • Bugfix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested by Login and Signup, and saving the data in Coredata.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@vatsalkul
Copy link
Member

Can you check why these tests are failing:
Failing tests:
mentorship iosTests:
HomeTests.testUserFirstName()
HomeTests.testUserFirstName()
HomeTests.testUserFirstName()
ProfileTests.testGetProfileService()

@paraschhugani
Copy link
Author

I made a change in name of the variable and it caused the error. I will make a commit soon. thanks for the review.

@paraschhugani
Copy link
Author

I am new to Travis Ci , I think some issue here

Screenshot 2021-01-22 at 3 45 36 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants