Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Medium icon is now visible in Docusaurus footer #1149

Closed
wants to merge 1 commit into from

Conversation

sumushi
Copy link

@sumushi sumushi commented Oct 22, 2021

Description

The medium link was added but its icon was not visible. So, added it to the items Array.

Fixes #1148

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

No tests needed.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@welcome
Copy link

welcome bot commented Oct 22, 2021

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1149 (ccbcb69) into develop (94daff8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1149   +/-   ##
========================================
  Coverage    94.99%   94.99%           
========================================
  Files           38       38           
  Lines         2058     2058           
========================================
  Hits          1955     1955           
  Misses         103      103           

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also add the screenshot of the icon being displayed on the footer in the PR description?

@isabelcosta isabelcosta added the Status: Changes Requested Changes are required to be done by the PR author. label Oct 26, 2021
@isabelcosta
Copy link
Member

@sumushi do you have any doubt about @vj-codes's request?

@vj-codes
Copy link
Member

Closing this PR due to inactivity
Thank you for your contribution @sumushi :)

@vj-codes vj-codes closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Medium icon which is hidden on Docusaurus footer
3 participants