-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1166: Migration to Paging3 for MembersFragment #1221
Open
bosankus
wants to merge
35
commits into
anitab-org:develop
Choose a base branch
from
bosankus:paging3-member-list
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6743c2c - Browse repository at this point
Copy the full SHA 6743c2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2527493 - Browse repository at this point
Copy the full SHA 2527493View commit details
Commits on Dec 5, 2021
-
Completed flow from MembersViewModel to the UI via MemberPagingAdapter
- Upon scroll MemberLoadingStateAdapter will show loading list or any error, with retry button to fetch further list. - list items are bind to UI now using databinding. See BindingUtils.kt - strings.xml have new additions. - pbMember progress bar removed from fragment_members.xml - yet to clean to codebase, and remove redundant methods.
Configuration menu - View commit details
-
Copy full SHA for aef5c56 - Browse repository at this point
Copy the full SHA aef5c56View commit details
Commits on Jan 7, 2022
-
Connected Room, RemoteMediator, UserDataManager to let data flow to M…
…embersViewModel.kt - local package: Room db created - RemoteMediator added for fetching & storing data from remote to local room db. - solved null check errors due to change of 'id' field in User.kt is changed to non-null - compileSdk and targetSdk, Kotlin, paging library versions updated. Supports latest version of room - Room dependencies added - Dependencies.kt - solved errors caused due to change in UserDataManager.kt class parameters. - Injection.kt added for injecting UserDataManager.kt to dependent classes
Configuration menu - View commit details
-
Copy full SHA for b61ef0b - Browse repository at this point
Copy the full SHA b61ef0bView commit details
Commits on Mar 1, 2022
-
fix: Crash on MemberProfileActivity.kt
- fixed the crash due to passing null data from MembersFragment.kt to MemberProfileActivity.kt
Configuration menu - View commit details
-
Copy full SHA for 28da24b - Browse repository at this point
Copy the full SHA 28da24bView commit details
Commits on Sep 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5d984a7 - Browse repository at this point
Copy the full SHA 5d984a7View commit details
Commits on Oct 3, 2022
-
Code clean: Removed unused methods and imports
- removed unused method from UserDataManager.kt - removed unused code and imports from MembersViewModel.kt - changed items per page to 50 - fixed spotless isssues.
Configuration menu - View commit details
-
Copy full SHA for 08ad17e - Browse repository at this point
Copy the full SHA 08ad17eView commit details
Commits on Oct 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aca6bf6 - Browse repository at this point
Copy the full SHA aca6bf6View commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 08d74b0 - Browse repository at this point
Copy the full SHA 08d74b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f285da2 - Browse repository at this point
Copy the full SHA f285da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d651fea - Browse repository at this point
Copy the full SHA d651feaView commit details
Commits on Oct 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 33fa76b - Browse repository at this point
Copy the full SHA 33fa76bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a28a236 - Browse repository at this point
Copy the full SHA a28a236View commit details -
Configuration menu - View commit details
-
Copy full SHA for be39931 - Browse repository at this point
Copy the full SHA be39931View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7328a1 - Browse repository at this point
Copy the full SHA e7328a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf0818 - Browse repository at this point
Copy the full SHA 4bf0818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f8b9b - Browse repository at this point
Copy the full SHA 41f8b9bView commit details
Commits on Oct 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0ee37b9 - Browse repository at this point
Copy the full SHA 0ee37b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67379dc - Browse repository at this point
Copy the full SHA 67379dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbf64a7 - Browse repository at this point
Copy the full SHA fbf64a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e5694f - Browse repository at this point
Copy the full SHA 1e5694fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f55a0 - Browse repository at this point
Copy the full SHA c1f55a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8663377 - Browse repository at this point
Copy the full SHA 8663377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c3896 - Browse repository at this point
Copy the full SHA 14c3896View commit details -
Configuration menu - View commit details
-
Copy full SHA for e70895d - Browse repository at this point
Copy the full SHA e70895dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 864b16e - Browse repository at this point
Copy the full SHA 864b16eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d71923f - Browse repository at this point
Copy the full SHA d71923fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fbdc2f - Browse repository at this point
Copy the full SHA 8fbdc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 950f8cf - Browse repository at this point
Copy the full SHA 950f8cfView commit details
Commits on Oct 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f11ea42 - Browse repository at this point
Copy the full SHA f11ea42View commit details -
Configuration menu - View commit details
-
Copy full SHA for f28a607 - Browse repository at this point
Copy the full SHA f28a607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7038a97 - Browse repository at this point
Copy the full SHA 7038a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 280d681 - Browse repository at this point
Copy the full SHA 280d681View commit details -
Configuration menu - View commit details
-
Copy full SHA for f43ee12 - Browse repository at this point
Copy the full SHA f43ee12View commit details
Commits on Nov 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 72f7f2f - Browse repository at this point
Copy the full SHA 72f7f2fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.