Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar, home page and other routers for the different pages site in reactjs #217

Closed
wants to merge 1 commit into from

Conversation

Shruti3004
Copy link
Contributor

@Shruti3004 Shruti3004 commented Feb 2, 2021

Description

An idea was pitched to convert the existing code into reactjs for its responsiveness and make it a PWA

Fixes #196

Type of Change:

  • Code
  • Quality Assurance
  • User Interface

How Has This Been Tested?

If you are working on a design then add a gif to show the responsiveness of your design.
Screenshot from 2021-02-02 11-37-26
Screenshot from 2021-02-02 11-37-30
Screenshot from 2021-02-02 11-37-32
Screenshot from 2021-02-02 11-37-35
Screenshot from 2021-02-02 11-37-40
Screenshot from 2021-02-02 11-37-44

Please follow testing guidelines and share the link of deployed site here.
https://anitab-org-reactjs.netlify.app/

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have attached link of deployed site.
  • Any dependent changes have been merged

Code/Quality Assurance Only:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Shruti3004
Copy link
Contributor Author

@annabauza please have a look over it!

@Shruti3004
Copy link
Contributor Author

@annabauza please review!

Copy link
Contributor

@annabauza annabauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we speak. Move it to the top and create wrappers for existing reactjs pages, then use router to display what we have atm. Ones you do that we can start replacing components and pages one by one. What you need to do is make sure router works on static github pages. We tried that before without success.

@@ -0,0 +1,70 @@
# Getting Started with Create React App
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this readme?

@annabauza annabauza added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Changes Requested Changes are required to be done by the PR author. labels Feb 3, 2021
@nandini45
Copy link
Member

@Shruti3004 can you make the changes as requested?

@keshakaneria
Copy link
Member

@Shruti3004 Any updates about the changes requested?

@Shruti3004
Copy link
Contributor Author

@keshakaneria I'll be working on it and will make the pr asap

@isabelcosta
Copy link
Member

Thank you for your work @Shruti3004 ! Will close due to lack of updates, and make the issue available again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp of the home page of website for responsiveness in react js
5 participants