Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding : Develop Introduction section of Home Page #109

Open
3 tasks
vj-codes opened this issue Jul 26, 2020 · 71 comments
Open
3 tasks

Coding : Develop Introduction section of Home Page #109

vj-codes opened this issue Jul 26, 2020 · 71 comments
Assignees
@sanchibansal340
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.

Comments

@vj-codes
Copy link
Member

vj-codes commented Jul 26, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

As a developer,
I need the following section to be developed so that I can add is as a Home component here

Mocks

Develop this section only
Screenshot (31)_LI

overall margin: 32pt
In between each section: 32pt
distance between image and text: 32pt
distance from horizontal line: 32pt
Avenir Body light 18pt
Heading 24pt
Text Color:#103B81
Design link for development

Acceptance Criteria

Update [Required]

  • Should follow all the margin guidelines mentioned above and should be responsive

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

6-8 hours
@vj-codes vj-codes added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jul 26, 2020
@nandini45
Copy link
Member

@anitab-org/coding-team can anyone take up this issue?

@Sonal240
Copy link
Contributor

@vj-codes the margins are incorrect

@Sonal240 Sonal240 added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jul 28, 2020
@vj-codes
Copy link
Member Author

@Sonal240 which ones? I checked with the doc didn't find any

@Sonal240
Copy link
Contributor

Sonal240 commented Jul 28, 2020 •
edited
Loading

It's not 16...it's 32 in total see the doc. I have not designed a separate component or so, hence I didn't break 32pt margin to 16-16...

@Sonal240 Sonal240 mentioned this issue Jul 28, 2020
Open
3 tasks
@saideepesh000
Copy link
Contributor

@Sonal240 , @nandini45, @vj-codes I would like to work on it.

@sakshi1499
Copy link

@saideepesh000 Its on hold right now, we'll get back to you once its confirmed.

@nandini45
Copy link
Member

@vj-codes did you update the design metrics?

@vj-codes vj-codes added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels Aug 16, 2020
@vj-codes
Copy link
Member Author

vj-codes commented Aug 16, 2020 •
edited
Loading

@nandini45 @Sonal240 please check once!

@Sonal240
Copy link
Contributor

The screenshot is not visible @vj-codes

@vj-codes
Copy link
Member Author

The screenshot is not visible @vj-codes

It is visible,can you try refreshing? I'm on phone right it's visible on it tooScreenshot_2020-08-17-11-28-19-825_com.github.android.jpg

@Sonal240
Copy link
Contributor

Sonal240 commented Aug 17, 2020 •
edited
Loading

it's not I tried refreshing it as well

@Sonal240
Copy link
Contributor

on clicking the link it is though...so I don't think it would create an issue...

@adithyaakrishna
Copy link
Contributor

Can I work on this issue? :)

@vj-codes
Copy link
Member Author

@saideepesh000 would you like to work on this?Otherwise it'll be assigned to the person next :)

@saideepesh000
Copy link
Contributor

@saideepesh000 would you like to work on this?Otherwise it'll be assigned to the person next :)

@vj-codes , right now I am working on an issue in this repo and also I've raised my PR, so, you can assign it to anyone else, thanks.

@vj-codes
Copy link
Member Author

Can I work on this issue? :)

Sure assigning you @adithyaakrishna
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 21, 2020
@adithyaakrishna
Copy link
Contributor

Thank You! :) @vj-codes

@nandini45
Copy link
Member

@adithyaakrishna any updates?

@Sonal240
Copy link
Contributor

@khushishikhu this issue is assigned to someone else may you please look for some other issue thanks 😊

@adithyaakrishna
Copy link
Contributor

Hi @nandini45 @Sonal240 , Sorry for not giving updates here, but I'm currently held up with my final year project work, you can assign it to @khushishikhu

@nandini45
Copy link
Member

ok

@purnima143
Copy link

@nandini45 @tichnas I wanna give small advice regarding the homepage design. The current state of the homepage is full with texts only, that looks bulky.

  • Keep the page minimalistic and free of clutter. In someplace instead of text, you can use more images and icons to present your thought.

  • “Readability” measures how easy it is for people to recognize words, sentences, and phrases.

  • Create one contrasting landing page, that will change the entire look.

I hope my advice will be helpful for you guys to design the beautiful homepage.🙂

@tichnas
Copy link
Contributor

tichnas commented Nov 27, 2020

@nandini45 @vj-codes What changes do you suggest considering @purnima143's advice?

@nandini45
Copy link
Member

nandini45 commented Dec 8, 2020 •
edited
Loading

@tichnas apology for the late reply
As far as her advice is considered
I agreed her points are perhaps correct but right now i can't ask u to redesign it again.. there are many features which we will need to work on. I will say do what was initially said , if u can make minimal changes without affecting the proposed design.. well and good..make changes but dont change the layouts

@tichnas
Copy link
Contributor

tichnas commented Dec 10, 2020

@nandini45 No issues.
To be sure that I did what was expected, can you please see the final screen-shot before opening a PR.

image

@nandini45
Copy link
Member

@tichnas it looks great..please go ahead with the PR

tichnas added a commit to tichnas/anitab-org.github.io that referenced this issue Dec 12, 2020
@tichnas
Coding : Develop Introduction section of Home Page
9898519 
Fixes anitab-org#109
@tichnas tichnas mentioned this issue Dec 12, 2020
Closed
3 tasks
@annabauza
Copy link
Contributor

@tichnas I release this issue due to lack of respond.

@annabauza annabauza added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 7, 2021
@prachinandi
Copy link

prachinandi commented Feb 8, 2021 •
edited
Loading

@annabauza ma'am so basically we need to code the front-end of the home page right, like the design that have been proposed above or ma'am can I propose a new design for the home page, and send the code as well.
I have a good practice in UX/UI design😅

@nandini45
Copy link
Member

nandini45 commented Feb 23, 2021 •
edited
Loading

@prachi237 the design has been finalized . you just have to code it.
if you can i will assign you the issue
if you want any clarification regarding the design you can ping me

@prachinandi
Copy link

@nandini45 yes ma'am I would like to work on it, but can u plz send be the UI details and tech stacks to be used

@nandini45
Copy link
Member

@prachi237 no ma'am please just nandini.
tech stack is angular JS
ui details see this our home page here a small section is not there
you have to develop that only
image

this is what you have to add
image

although if u want to contribute more to designing specifically you can join our design team on zulip

@vj-codes
Copy link
Member Author

@nandini45 I think it's react js not angular js for tech stack , do confirm .

@Aaishpra
Copy link
Member

@nandini45 @vj-codes actually react native is used here😉 i am sure of it

@vj-codes
Copy link
Member Author

@Aaishpra yes earlier we used native now we are moving to react js
(check comment by Anna here )

@Aaishpra
Copy link
Member

@Aaishpra yes earlier we used native now we are moving to react js
(check comment by Anna here )

Ohh really thanks for informing @vj-codes

@nandini45
Copy link
Member

nandini45 commented Feb 25, 2021 via email

@nandini45
Copy link
Member

@prachi237 are you working on it?
if not i will un-assign you

@sanchibansal340
Copy link

@nandini45 From what I understand the code has now been converted to ReactJS, right?
If yes, can I please try to work on this issue, if available?

@nandini45
Copy link
Member

@sanchibansal340 sure, i assigned the issue to you

@nandini45 nandini45 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 2, 2021
@sanchibansal340
Copy link

Hi @nandini45, I am done with the issue. Below are the changes that I have made, let me know the changes. From the previous PR, it looks like Lorem Ipsum text isn't accepted, any updates about the actual content?
Screenshot (172)

@sanchibansal340
Copy link

Hi @nandini45, I am done with the issue. Below are the changes that I have made, let me know the changes. From the previous PR, it looks like Lorem Ipsum text isn't accepted, any updates about the actual content?
Screenshot (172)

@vj-codes Can you please look into this?

@vj-codes
Copy link
Member Author

@sanchibansal340 the intro part that I see when logging in on zulip might be good except for the last 2 lines in the screenshot below.
@isabelcosta @annabauza what say?

Screenshot (59)

@sanchibansal340
Copy link

@vj-codes hey I totally forgot about this issue. Shall I move forward with this content then?

@nandini45
Copy link
Member

@sanchibansal340 i agree with @vj-codes . update it and submit the PR .
we will review it
thanks

@mudrikapandey
Copy link

Is this issue is solved ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanchibansal340 sanchibansal340

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Introduction section of Home Page tichnas/anitab-org.github.io