Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding: Develop the following section for Home Page #110

Open
3 tasks
vj-codes opened this issue Jul 26, 2020 · 32 comments
Open
3 tasks

Coding: Develop the following section for Home Page #110

vj-codes opened this issue Jul 26, 2020 · 32 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days.

Comments

@vj-codes
Copy link
Member

vj-codes commented Jul 26, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

As a developer,
I need the following section to be developed so that I can add is as a Home component here

Mocks

Develop this section only

Screenshot (32)_LI

overall margin: 32pt
Margin top for GETTING STARTED heading: 64pt
In between each section: 32pt
distance between image and text: 32pt
distance from horizontal line: 32pt
Avenir Body light 18pt
Heading 24pt
Text Color:#103B81

Design link for development

Acceptance Criteria

Update [Required]

  • Should follow all the margin guidelines mentioned above and should be responsive

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

6-8 hours
@vj-codes vj-codes added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jul 26, 2020
@nandini45
Copy link
Member

@anitab-org/coding-team can anyone take up this issue?

@Sonal240
Copy link
Contributor

@vj-codes the margins are incorrect

@Sonal240 Sonal240 added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jul 28, 2020
@vj-codes
Copy link
Member Author

@Sonal240 which ones? I checked in the doc didn't find any

@Sonal240
Copy link
Contributor

Sonal240 commented Jul 28, 2020 •
edited
Loading

overall margin: 32pt
Margin top for GETTING STARTED heading: 64pt
In between each section: 32pt
distance between image and text: 32pt
distance from horizontal line: 32pt
Avenir Body light 18pt
Heading 24pt
Text Color:#103B81

@vj-codes
Copy link
Member Author

@Sonal240 I see a mess has been sent on zulip to , will change accordingly.BTW the metrics say body is still 14 pt , when was it changed to 18pt?

@Sonal240
Copy link
Contributor

Well I remember last time when Anna had introduced the doc she mentioned this...also note that if body is 14pt then how can View More be 16pt? Body should be given more emphasis than view more right?

@nandini45
Copy link
Member

@vj-codes
complete and update the labelling please
there are contributors looking for new issues . if you can update this issue and other one we can make it available as soon as possible

@vj-codes vj-codes added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels Aug 16, 2020
@vj-codes
Copy link
Member Author

@Sonal240 @nandini45 check once please!

@Sonal240
Copy link
Contributor

LGTM @vj-codes !!

@raksh543
Copy link

I am willing to work on this.

@gaurivn gaurivn removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 22, 2020
@raksh543
Copy link

Will you be providing the four images as present in design or can i use any sample image?

@Sonal240
Copy link
Contributor

Give me 10 min I'll share link for development

@Sonal240
Copy link
Contributor

https://xd.adobe.com/view/09a9fdf0-a193-4b3f-47c2-216055c7ca42-7f98/
is it working? are you able to download it?

@raksh543
Copy link

Yes now its working, i am able to download

@raksh543
Copy link

I also wanted to ask that what are the dimensions of the image to be displayed?

@Sonal240
Copy link
Contributor

kindly click on the image and see the properties

@raksh543
Copy link

screencapture-localhost-3000-2020-08-25-20_53_39
Update of work:
This is the screen shot of things that have been implemented.
Work left: Responsiveness and final checking the margins.

@raksh543
Copy link

Screenshot (149)
The Ways to contribute section looks like this. It got overlapped in the previous screenshot.

@raksh543 raksh543 mentioned this issue Aug 29, 2020
Closed
4 tasks
@tichnas
Copy link
Contributor

tichnas commented Nov 20, 2020

@raksh543 Are you working on the changes requested in the PR?

@Aaishpra
Copy link
Member

Aaishpra commented Dec 9, 2020

@nandini45 @Sonal240 I don't see updates from the current assignee for the requested changes in the PR .
So, can i work on this?

@Sonal240
Copy link
Contributor

Let's wait for 1 or 2 days
@raksh543 May you please work on the changes requested else this issue would be assigned to
@Aaishpra

@raksh543
Copy link

@Sonal240 I would continue to work on this. Pr for this issue have already been made. There are some minor fixes needed, so i would complete that.

@Sonal240
Copy link
Contributor

Kindly complete them asap @raksh543

@tichnas
Copy link
Contributor

tichnas commented Dec 25, 2020

@raksh543 Are you working on the changes?
If not, can I please work on it @Sonal240? Thanks

@tichnas
Copy link
Contributor

tichnas commented Jan 2, 2021

@nandini45 I think this work is already done. Can you please confirm?

@nandini45
Copy link
Member

@tichnas yes the work is done. You can see it in this PR
#134

@tichnas
Copy link
Contributor

tichnas commented Jan 2, 2021 •
edited
Loading

@nandini45 No, I think the work is already merged as it's visible to me and we no longer require that PR (or this issue).

This is the work visible to me:
image

@shades-7
Copy link
Contributor

@nandini45 hey is this issue still open, can I work on this?

1 similar comment
@shades-7
Copy link
Contributor

@nandini45 hey is this issue still open, can I work on this?

@nandini45
Copy link
Member

@shades-7 i dont know the current status of the issue. i will get back to you
and i think you have a issue already in hand complete that
after that i can assign you this one.

@isabelcosta isabelcosta added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 17, 2021
@nawed2611
Copy link

Hi! Is this issue still open? I would like to work on it.

@preeti13456
Copy link

This issue must be closed since all the asked sections were already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a section of home page raksh543/anitab-org.github.io