-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add feature to fill, edit and view form responses for users #103
Conversation
@isabelcosta this PR is not yet completed (basically facing issues while testing these features), and I will not be able to write tests for this feature, (as my university has declared exams and practicals starting from the 5th of this month😢 ) Can you assign the task of writing test (after this features are completed and tested) to someone else in the community. In the meantime can someone else in the community test and review this PR and suggest some ways I can use to make these features work properly 🙏🏻 (I won't be available much for the time being but will try to make changes to the PR as soon as I get time while giving exams). Apologies 🙏🏻 from my side, I didn't know I would be stuck in this type of situation and would have to pause my work for this PR. |
@Aaishpra Can you now update the PR? |
@codesankalp i am currently busy with some commitments will update the work here after a week |
Update: I am back and resuming my work on this. |
Cool @Aaishpra 🤗 thank you for updating us :) |
Is it ready for testing? |
Facing some compilation error because of prettier/prettier |
Ok, Is it happening generally i.e. for develop branch or for this branch? |
For this branch, basically for preview.js. Don't worry though i will try to compile the code after removing prettier (turn it into warning) and will test if there is a problem with the code or something else |
Can you check if it's working for u or not? |
Yes, I will check. |
I checked it and tested it for different scenarios. But it's not working for me. Submitting the form also doesn't seem to work (because the reference to the question is present in the backend but the answer is absent). Also after submitting the form remains open and no success message is shown. I can't see responses for any form in the submissions tab. Also, I see there are many commits that are on develop branch that is not present here. |
@Aaishpra Have you addressed issues that I have seen? |
Sorry, I don't have time to work on this currently. Shall i just close this. @codesankalp |
If you will complete this in the future then there is no point in closing this PR. 👍 |
Sure then I will get back to it after some time |
I think we can close this and see if someone else can continue the issue, but if no one picks up and @Aaishpra wants to continue, we can reopen and you can pick up where you left off :) cc @codesankalp |
following up on this, I'll close and make the issue available again. Feel free to let us know in the issue if you want to work on this again @Aaishpra |
No problem Isabel, if the issue is available in future I will get back to it.🙌🏻 |
Nice! Thank you for understanding 🤗 |
Description
Currently, this Pull Request is WIP because of some untested features and errors
Will update the description after the PR is complete.
Fixes #10
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only