Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add feature to fill, edit and view form responses for users #103

Closed
wants to merge 5 commits into from

Conversation

Aaishpra
Copy link
Member

@Aaishpra Aaishpra commented Mar 1, 2021

Description

Currently, this Pull Request is WIP because of some untested features and errors
Will update the description after the PR is complete.

Fixes #10

Type of Change:

  • Code
  • User Interface
  • Outreach

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Aaishpra
Copy link
Member Author

Aaishpra commented Mar 1, 2021

@isabelcosta this PR is not yet completed (basically facing issues while testing these features), and I will not be able to write tests for this feature, (as my university has declared exams and practicals starting from the 5th of this month😢 ) Can you assign the task of writing test (after this features are completed and tested) to someone else in the community.

In the meantime can someone else in the community test and review this PR and suggest some ways I can use to make these features work properly 🙏🏻 (I won't be available much for the time being but will try to make changes to the PR as soon as I get time while giving exams).

Apologies 🙏🏻 from my side, I didn't know I would be stuck in this type of situation and would have to pause my work for this PR.

@Aaishpra Aaishpra added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Mar 7, 2021
@codesankalp
Copy link
Member

@Aaishpra Can you now update the PR?

@Aaishpra
Copy link
Member Author

@codesankalp i am currently busy with some commitments will update the work here after a week

@Aaishpra
Copy link
Member Author

Aaishpra commented May 3, 2021

Update: I am back and resuming my work on this.

@isabelcosta
Copy link
Member

Cool @Aaishpra 🤗 thank you for updating us :)

@codesankalp
Copy link
Member

Is it ready for testing?

@Aaishpra
Copy link
Member Author

Facing some compilation error because of prettier/prettier

@codesankalp
Copy link
Member

Facing some compilation error because of prettier/prettier

Ok, Is it happening generally i.e. for develop branch or for this branch?

@Aaishpra
Copy link
Member Author

For this branch, basically for preview.js. Don't worry though i will try to compile the code after removing prettier (turn it into warning) and will test if there is a problem with the code or something else

@Aaishpra
Copy link
Member Author

Aaishpra commented May 31, 2021

Is it ready for testing?

Can you check if it's working for u or not?

@codesankalp
Copy link
Member

Is it ready for testing?

Can you check if it's working fir u or not?

Yes, I will check.

@codesankalp
Copy link
Member

Is it ready for testing?

Can you check if it's working for u or not?

I checked it and tested it for different scenarios. But it's not working for me.
The editing form feature is also not good - the dropdown is in a very small space, if I change the type of question then there is no option for adding options, checkboxes, or choices.

Submitting the form also doesn't seem to work (because the reference to the question is present in the backend but the answer is absent). Also after submitting the form remains open and no success message is shown.

I can't see responses for any form in the submissions tab.

Also, I see there are many commits that are on develop branch that is not present here.

@codesankalp
Copy link
Member

@Aaishpra Have you addressed issues that I have seen?

@Aaishpra
Copy link
Member Author

Sorry, I don't have time to work on this currently. Shall i just close this. @codesankalp

@codesankalp
Copy link
Member

Sorry, I don't have time to work on this currently. Shall I just close this. @codesankalp

If you will complete this in the future then there is no point in closing this PR. 👍

@Aaishpra
Copy link
Member Author

Sure then I will get back to it after some time

@isabelcosta
Copy link
Member

I think we can close this and see if someone else can continue the issue, but if no one picks up and @Aaishpra wants to continue, we can reopen and you can pick up where you left off :)

cc @codesankalp

@isabelcosta
Copy link
Member

I think we can close this and see if someone else can continue the issue, but if no one picks up and @Aaishpra wants to continue, we can reopen and you can pick up where you left off :)

cc @codesankalp

following up on this, I'll close and make the issue available again. Feel free to let us know in the issue if you want to work on this again @Aaishpra

@isabelcosta isabelcosta closed this Oct 2, 2021
@Aaishpra Aaishpra deleted the forms branch October 2, 2021 10:57
@Aaishpra
Copy link
Member Author

Aaishpra commented Oct 2, 2021

No problem Isabel, if the issue is available in future I will get back to it.🙌🏻

@isabelcosta
Copy link
Member

Nice! Thank you for understanding 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an User, I am able to fill, edit and view the form
3 participants