fix(android): setup JNI support for non-rust Android apps #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Jun 4, 2024
Tommylans
approved these changes
Jun 4, 2024
src/android.rs
Outdated
| let p = jni_call_method!(env, &self.0, KEY_PAIR_GET_PUBLIC, l, UnableToGetPublicKey)?; | ||
| let key = unsafe { self.get_object() }; | ||
|
|
||
| let p = jni_call_method!(env, &key, KEY_PAIR_GET_PUBLIC, l, UnableToGetPublicKey)?; |
There was a problem hiding this comment.
What do you mean?
Yes, thank god!!!! |
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
jni-support-for-non-rust-android-apps
branch
from
55a293d to
b6693c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short ramble time.
When testing the library within React Native I noticed that the
JAVA_VMwas not set, this is due to the fact the example app in this repository usesandroid_activitywhich sets this variable inside another library... This took some time to find :)After I found that out, I had to set the
JAVA_VMpointer myself, I have triedJNI_OnLoadandANativeActivity_onCreateand both were not triggered (even though this library and AriesAskar had the public symbol in their library...).Currently this is the best solution I could come up with. It does mean that the user, for Android, needs to create a java file, as described in the README, which is a bit annoying. Would like to revisit this in the future, but for now it unblocks progress for the ARF and Askar at least.