fix: disable user precense requirement #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
berendsliedrecht
commented
May 16, 2024
•
berendsliedrecht
commented
- Disables user precense required
- Correctly propegate Android errors to Rust with more context
berendsliedrecht
force-pushed
the
disable-user-precense
branch
from
dd8a6a8 to
eb7e853
Compare
Tommylans
approved these changes
May 16, 2024
| })?; | ||
|
|
||
| let msg_rust: String = $env | ||
| .get_string(&message.into()) |
There was a problem hiding this comment.
Why would you not do the into() with the message variable but you do it with the msg_rust variable. This is inconsistent
berendsliedrecht
force-pushed
the
disable-user-precense
branch
from
eb7e853 to
618260c
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
disable-user-precense
branch
from
618260c to
0b7481e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.