fix(apps): address functions deployment compatibility and resolve callable signature issues#3565
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the application's architecture and security by moving data access to backend callable functions and locking down Firestore. The changes are well-structured and address important deployment compatibility issues. I've found one high-severity issue in the new updateUser function where handling for indefinite blocks is incorrect, which could lead to storing invalid data. A fix is suggested.
josephperrott
force-pushed
the
fix-callable-deploy
branch
from
91e5589 to
c816db4
Compare
…lable signature issues
josephperrott
force-pushed
the
fix-callable-deploy
branch
from
c816db4 to
a14d4bf
Compare
alan-agius4
approved these changes
Mar 24, 2026
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes refactored callable return structure and CommonJS deployment stabilizing fixes.