Merged
Conversation
crisbeto
added
target: patch
crisbeto
added
target: minor
ok7sai
approved these changes
Apr 9, 2026
Now that we're rendering the autocomplete popover inline, we no longer need the `aria-owns` workaround.
Now that we're rendering the select popover inline, we no longer need the `aria-owns` workaround.
crisbeto
force-pushed
the
modal-workarounds
branch
from
995dc0a to
300f6c4
Compare
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few months ago we switched to rendering the select and autocomplete modals inline which means that we don't need the
aria-ownsworkaround anymore.