fix(material/tooltip): tooltip inside sidenav hides after text update#32980
Closed
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Closed
fix(material/tooltip): tooltip inside sidenav hides after text update#32980yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
When a tooltip overflows a parent scrollable container (e.g. mat-sidenav) and its text is updated dynamically, the tooltip incorrectly hides. This happens because updating the message triggers a reposition, which causes the overlay clip check to detect the tooltip extending beyond the scrollable ancestor bounds and hide it. Skip the overlay clip check when the reposition is triggered by a message update rather than a user scroll event. Fixes angular#27782 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
This is pure hallucinated slop. Please stop pointing your Claude instance at random issues and relying on us to verify if the code it produced actually makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mat-sidenavhiding when its text content is updated dynamicallyupdatePosition()triggers the overlay clip check which incorrectly detects the tooltip as clipped and hides it_isRepositioningForMessageflag to skip the clip check during message-driven repositioningRoot Cause
mat-sidenavcontent extendsCdkScrollable, making it a registered scrollable ancestor_updateTooltipMessage()→updatePosition()→positionChangesemissionpositionChangessubscriber checksisOverlayClippedagainst scrollable ancestorsTest plan
Fixes #27782
🤖 Generated with Claude Code