Token extraction updates #29846
Merged
Token extraction updates #29846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tokens extraction script assumes that all the imported tokens will be used in the `overrides` mixin. That's true for all themes, except for `core` which only supports some of the mixins. These changes add a separate function that `core` can use to tell the tokens extraction script about which tokens are supported.
crisbeto
added
target: patch
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Oct 9, 2024
crisbeto
force-pushed
the
core-theme-tokens
branch
from
cac59c4
to
bba68bd
Compare
We have many cases where we output a token with the same name under different prefixes from a theme. The way we were grouping the token data meant that this information was being lost. These changes rework the data so each token has an array of `sources` that describe where the token is coming from.
crisbeto
force-pushed
the
core-theme-tokens
branch
from
bba68bd
to
a869e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a couple of changes (see individual commits) to ensure that we extract tokens correctly from the
core-themeand that we correctly reflect tokens whose names overlap between different prefixes.