Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: rework tokens extraction #29842

Merged
merged 1 commit into from
Oct 8, 2024
Merged

build: rework tokens extraction #29842

merged 1 commit into from
Oct 8, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 7, 2024

Reworks how we extract the tokens so we can output override calls instead of the full CSS variables.

@crisbeto
build: rework tokens extraction
a661e5f 
Reworks how we extract the tokens so we can output `override` calls instead of the full CSS variables.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 7, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 7, 2024
@crisbeto crisbeto marked this pull request as ready for review October 7, 2024 19:25
@crisbeto crisbeto requested a review from a team as a code owner October 7, 2024 19:25
devversion
devversion approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clever and clean! but also feels like Sass interplay could be better :D

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 8, 2024
@crisbeto crisbeto removed the request for review from andrewseguin October 8, 2024 06:57
@crisbeto crisbeto merged commit be543d1 into angular:main Oct 8, 2024
26 of 28 checks passed
crisbeto added a commit that referenced this pull request Oct 8, 2024
@crisbeto
build: rework tokens extraction (#29842)
d74bec3 
Reworks how we extract the tokens so we can output `override` calls instead of the full CSS variables.

(cherry picked from commit be543d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @devversion