-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date adapter changes #29799
Merged
Merged
Date adapter changes #29799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: major
This PR is targeted for the next major release
merge: preserve commits
When the PR is merged, a rebase and merge should be performed
labels
Sep 28, 2024
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
September 28, 2024 07:10
crisbeto
force-pushed
the
prereq-changes
branch
from
September 28, 2024 09:34
adb218c
to
0a0c898
Compare
crisbeto
force-pushed
the
prereq-changes
branch
2 times, most recently
from
September 30, 2024 08:06
b588019
to
12ac986
Compare
Expands the date adapter to include some methods that will be used in the future.
Implements the new methods in the Moment adapter.
Implements the new methods in the Luxon adapter.
Implements the new methods in the `date-fns` adapter.
Expands the `MAT_INPUT_VALUE_ACCESSOR` to support a signal-based accessor.
…signal Expands the `MatOptionParentComponent` to allow the `disableRipple` to be a signal. This will be relevant in the time picker.
crisbeto
force-pushed
the
prereq-changes
branch
from
September 30, 2024 08:36
12ac986
to
db0f61f
Compare
mmalerba
reviewed
Sep 30, 2024
mmalerba
approved these changes
Sep 30, 2024
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 30, 2024
Makes the changes that came up during the code review of angular#29799, but weren't pushed to the branch by accident.
crisbeto
added a commit
that referenced
this pull request
Sep 30, 2024
Makes the changes that came up during the code review of #29799, but weren't pushed to the branch by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
merge: preserve commits
When the PR is merged, a rebase and merge should be performed
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a few adjustments to the date adapters.