fix(material/list): fix text trim #29758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix text trim issue where visual users won't be able to see if list item text is overflowed in container fixes b/291296866
update api golden fixes b/291296866
update api golden fixes b/291296866
make func private fixes b/291296866
DBowen33
requested review from
crisbeto and
andrewseguin
and removed request for
a team
jelbourn
added
the
dev-app preview
|
Deployed dev-app for 87c41f6 to: https://ng-dev-previews-comp--pr-angular-components-29758-dev-yuh6xxfu.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
reviewed
Sep 19, 2024
|
|
||
| // In case text overflow is triggered and ellipsis is applied, adds role='tooltip' and title | ||
| // attribute to container so visual users can see the full text on hover | ||
| private _addTitleToTruncatedText() { |
There was a problem hiding this comment.
This won't work if the text changes and I don't think that we would want to poll the DOM for it. Given that users project the MatListItemLine themselves, it might be better to just update our a11y guidelines to mention adding role="tooltip" for longer text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix text trim issue where visual users won't be able to see full text if list item text is overflowed in container and ellipsis is shown.
fixes b/291296866
After: https://screencast.googleplex.com/cast/NDc3NDY5OTE0OTAzMzQ3Mnw3MjJlZjA2ZS05MQ
NOTE: cursor is slightly off from text container in video for some reason