Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/drag-drop): error if ngDevMode is undefined #29634

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(cdk/drag-drop): error if ngDevMode is undefined #29634

merged 1 commit into from
Aug 23, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the drag&drop module wasn't checking for ngDevMode correctly.

Fixes #29633.

@crisbeto
fix(cdk/drag-drop): error if ngDevMode is undefined
dcace7e 
Fixes that the drag&drop module wasn't checking for `ngDevMode` correctly.

Fixes angular#29633.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 23, 2024
@crisbeto crisbeto requested a review from a team as a code owner August 23, 2024 12:02
@crisbeto crisbeto requested review from mmalerba, wagnermaciel and devversion and removed request for a team August 23, 2024 12:02
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2024
@crisbeto crisbeto merged commit 2f1fe03 into angular:main Aug 23, 2024
22 of 25 checks passed
crisbeto added a commit that referenced this pull request Aug 23, 2024
@crisbeto
fix(cdk/drag-drop): error if ngDevMode is undefined (#29634)
39d3d01 
Fixes that the drag&drop module wasn't checking for `ngDevMode` correctly.

Fixes #29633.

(cherry picked from commit 2f1fe03)
@WontonSam WontonSam mentioned this pull request Sep 11, 2024
Open
@aam-digital-ci aam-digital-ci mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 19, 2024
Closed
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/drag-drop): error when ngDevMode is undefined
2 participants
@crisbeto @andrewseguin