Consolidate style loading logic #29617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: major
crisbeto
commented
Aug 21, 2024
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
added
merge: preserve commits
andrewseguin
approved these changes
Aug 21, 2024
src/cdk/private/style-loader.ts
Outdated
| * Loads a set of styles. | ||
| * @param loader Component which will be instantiated to load the styles. | ||
| */ | ||
| loadStyles(loader: Type<unknown>): void { |
There was a problem hiding this comment.
Usage looks a little redundant with styleLoader.loadStyles()
What about renaming this to just load
| @@ -0,0 +1 @@ | |||
| Private utilities meant to be used only within the CDK and Material. | |||
There was a problem hiding this comment.
This makes me wonder if this sort of utility is useful to other Angular component libraries. Maybe over time we could graduate these things to the framework or CDK
Creates a new `cdk/private` package in which we can put shared code that isn't meant to be public and creates a new style loader service that can be used to load structural styles for components.
…yles Switches the drag&drop module to use the common service to load the preview styles.
…tyles Switches the badge to use the common style loading service to load its structural styles.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
cdk/privateentrypoint that we can use for logic that needs to be shared, but shouldn't be public. Also moves our various implementations of style loading into it.