Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/chips): describe how to use chips in forms #22906 #29405

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

HermanWKeuris
Copy link
Contributor

Added a description and examples in the docs of how to use chips in both reactive and template-driven forms.

Fixes #22906

Added a description and examples in the docs of how to use chips in both reactive and template-driven forms.

Fixes angular#22906
@HermanWKeuris HermanWKeuris requested a review from a team as a code owner July 10, 2024 06:45
@HermanWKeuris HermanWKeuris requested review from amysorto and mmalerba and removed request for a team July 10, 2024 06:45
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jul 10, 2024
<h4>Chips inside of a Reactive form</h4>
<mat-form-field class="example-form-field">
<mat-label>Video keywords</mat-label>
<mat-chip-grid #reactiveChipGrid aria-label="Enter reactive form keywords" [formControl]="formControl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this file seems off. Maybe it's using tabs instead of spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use spaces instead of tabs

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 24, 2024
@crisbeto crisbeto merged commit 9ca2a0a into angular:main Jul 24, 2024
25 of 26 checks passed
crisbeto pushed a commit that referenced this pull request Jul 24, 2024
* docs(material/chips): describe how to use chips in forms

Added a description and examples in the docs of how to use chips in both reactive and template-driven forms.

Fixes #22906

* docs(material/chips): describe how to use chips in forms

Updated indentation

(cherry picked from commit 9ca2a0a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(MatChips): describe how to use chips with forms
2 participants