Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): PR NOW at https://github.com/angular/components/pull/29427 #29398

Closed
wants to merge 0 commits into from
Closed

fix(material/chips): PR NOW at https://github.com/angular/components/pull/29427 #29398

wants to merge 0 commits into from

Conversation

DBowen33
Copy link
Contributor

@DBowen33 DBowen33 commented Jul 8, 2024 •
edited
Loading

Fixed an issue to where users can get stuck in a focus trap in mat-grid. If a user were to try to navigate backwards out of the chip grid, the user gets stuck.

fixes b/290959510

@DBowen33 DBowen33 force-pushed the chip-focus-trap-fix branch 2 times, most recently from 5cbc86e to f503903 Compare July 9, 2024 14:56
@DBowen33 DBowen33 marked this pull request as ready for review July 9, 2024 14:57
@DBowen33 DBowen33 requested a review from a team as a code owner July 9, 2024 14:57
@DBowen33 DBowen33 requested review from crisbeto and andrewseguin and removed request for a team July 9, 2024 14:57
@DBowen33 DBowen33 changed the title Chip focus trap fix fix(material/chips): chip focus trap fix Jul 9, 2024
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 11, 2024
@andrewseguin andrewseguin removed their request for review July 11, 2024 21:27
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Jul 11, 2024
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Jul 12, 2024
@crisbeto
Copy link
Member

@DBowen33 the internal change for this was merged, but this PR can't be because of the merge commit. Can you remove it from your branch?

@angular-robot angular-robot bot added the detected: deprecation PR contains a commit with a deprecation label Jul 12, 2024
@angular-robot angular-robot bot requested a review from crisbeto July 12, 2024 14:38
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jul 12, 2024
@angular-robot angular-robot bot removed detected: deprecation PR contains a commit with a deprecation area: docs Related to the documentation labels Jul 12, 2024
@DBowen33 DBowen33 closed this Jul 12, 2024
@DBowen33 DBowen33 changed the title fix(material/chips): chip focus trap fix fix(material/chips): PR NOW at https://github.com/angular/components/pull/29427 Jul 12, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DBowen33 @crisbeto @andrewseguin