fix(material/list): Mat Selection List example is limited to html temp #29348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plating Updated the single selection list example from a template-driven form to a reactive form. Fixes angular#25894
MichelleRetroRabbit
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Jul 5, 2024
| <p> | ||
| Option selected: {{shoes.selectedOptions.hasValue() ? shoes.selectedOptions.selected[0].value : 'None'}} | ||
| </p> | ||
| <form [formGroup]="form"> |
There was a problem hiding this comment.
Rather than replacing the example, I think we should add another one with reactive forms.
crisbeto
reviewed
Jul 12, 2024
| name: string; | ||
| } | ||
| /** | ||
| * @title List with single selection using a reactive forms approach |
There was a problem hiding this comment.
using a reactive forms approach -> using Reactive forms
| @@ -0,0 +1,33 @@ | |||
| import {Component} from '@angular/core'; | |||
| import {FormControl, FormGroup, FormsModule, ReactiveFormsModule} from '@angular/forms'; | |||
| import {MatListModule} from '@angular/material/list'; | |||
There was a problem hiding this comment.
nit: add a new line after this import.
crisbeto
approved these changes
Jul 24, 2024
crisbeto
added
docs
|
@MichelleRetroRabbit the change looks good, but I can't merge it in because the branch contains a merge commit. Can you drop remove it? |
…plating Added a reactive forms example to the single selection list Fixes angular#25894
MichelleRetroRabbit
force-pushed
the
docs_bug_mat-selection-list_example
branch
from
f6de090
to
3bdaaa4
Compare
crisbeto
approved these changes
Aug 9, 2024
crisbeto
pushed a commit
that referenced
this pull request
Aug 9, 2024
…mp (#29348) * fix(material/list): Mat Selection List example is limited to html templating Updated the single selection list example from a template-driven form to a reactive form. Fixes #25894 * fix(material/list): Mat Selection List example is limited to html templating Added a reactive forms example to the single selection list Fixes #25894 (cherry picked from commit 2f49eaa)
crisbeto
pushed a commit
that referenced
this pull request
Aug 9, 2024
…mp (#29348) * fix(material/list): Mat Selection List example is limited to html templating Updated the single selection list example from a template-driven form to a reactive form. Fixes #25894 * fix(material/list): Mat Selection List example is limited to html templating Added a reactive forms example to the single selection list Fixes #25894 (cherry picked from commit 2f49eaa)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the single selection list example from a template-driven form to a reactive form.
Fixes #25894