refactor(material/core): simplify structural styles #29269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the structural styles of `mat-option` and `mat-optgroup` to make them easier to maintain.
crisbeto
requested review from
amysorto,
andrewseguin and
mmalerba
and removed request for
a team
mmalerba
approved these changes
Jun 17, 2024
| @@ -84,7 +79,7 @@ | |||
| // MatOption uses a child `<div>` element for its focus state to align with how ListItem does | |||
| // its focus state. | |||
| .mat-mdc-option-pseudo-checkbox, .mdc-list-item__primary-text, > mat-icon { | |||
| opacity: mdc-list-variables.$content-disabled-opacity; | |||
| opacity: 0.38; | |||
There was a problem hiding this comment.
This feels like maybe it should come from a token
There was a problem hiding this comment.
For now I'm focusing on forking off the styles, but once it's done, it should be easy to tokenize it.
crisbeto
added a commit
that referenced
this pull request
Jun 17, 2024
Simplifies the structural styles of `mat-option` and `mat-optgroup` to make them easier to maintain. (cherry picked from commit 607da66)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the structural styles of
mat-optionandmat-optgroupto make them easier to maintain.