-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(material/button): update button documentation and examples for M3 #29252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the examples, should we combine the button overview and the button types examples? I think they're basically showing the same thing.
Also once include an example of an extended FAB, we can resolve #29130 as well.
25a3a94
to
79453d9
Compare
79453d9
to
8c747fd
Compare
Ideally we use the same messaging across all inputs - want to follow this up with changing the rest of |
| `mat-raised-button` | Rectangular contained button w/ elevation | | ||
| `mat-flat-button` | Rectangular contained button w/ no elevation | | ||
| `mat-stroked-button` | Rectangular outlined button w/ no elevation | | ||
| `mat-button` | Rectangular text button w/ no elevation and rounded corners | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should mention the appearance here since it can change based on the tokens. I know this was here before so totally fine to also just leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was on the fence about that too, but technically the M3 specs call out that it has rounded corners and that is the default
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #29130