Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/button): update button documentation and examples for M3 #29252

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Jun 13, 2024

Fixes #29130

@amysorto amysorto added the target: patch This PR is targeted for the next patch release label Jun 13, 2024
@amysorto amysorto requested a review from a team as a code owner June 13, 2024 15:39
@amysorto amysorto requested review from crisbeto and andrewseguin and removed request for a team June 13, 2024 15:39
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 13, 2024
@amysorto amysorto added action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Jun 13, 2024
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the examples, should we combine the button overview and the button types examples? I think they're basically showing the same thing.

Also once include an example of an extended FAB, we can resolve #29130 as well.

@andrewseguin
Copy link
Contributor

Ideally we use the same messaging across all inputs - want to follow this up with changing the rest of color inputs?

| `mat-raised-button` | Rectangular contained button w/ elevation |
| `mat-flat-button` | Rectangular contained button w/ no elevation |
| `mat-stroked-button` | Rectangular outlined button w/ no elevation |
| `mat-button` | Rectangular text button w/ no elevation and rounded corners |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should mention the appearance here since it can change based on the tokens. I know this was here before so totally fine to also just leave it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was on the fence about that too, but technically the M3 specs call out that it has rounded corners and that is the default

@amysorto amysorto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Jun 13, 2024
@amysorto amysorto removed the request for review from andrewseguin June 13, 2024 19:43
@amysorto amysorto merged commit 5fa8f67 into angular:main Jun 13, 2024
22 of 24 checks passed
amysorto added a commit that referenced this pull request Jun 13, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Buttons): Buttons & FABs with support for Icon + label
3 participants