fix(cdk/scrolling): virtual-scroll flickers in zoneless mode #29175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When provideExperimentalZonelessChangeDetection is enabled, virtual-scroll-viewport flickers during scroll because the transform operation becomes visible. This fix uses AfterRenderPhase to ensure this operation stays invisible, despite provideExperimentalZonelessChangeDetection being used or not. Fixes #29174
mmalerba
approved these changes
Jun 4, 2024
|
Unfortunately these changes don't seem quite right. It causes a number of tests in google to fail, and I can see in the dev app ( |
|
Hi @mmalerba, tanks for the quick review. My bad, sorry for the time spent. Wish you the very best. |
OonihiloO
deleted the
fix/cdk-scrolling-virtual-scroll-flickers-in-zoneless-mode
branch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
provideExperimentalZonelessChangeDetectionis enabled,virtual-scroll-viewportflickers during scroll because thetransformoperation becomes visible.This fix uses
AfterRenderPhaseto ensure this operation stays invisible, despiteprovideExperimentalZonelessChangeDetectionbeing used or not.Fixes #29174