Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move M2 theming information into separate guide #29054

Merged
merged 2 commits into from
May 16, 2024

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented May 15, 2024

Move the M3 theme guide into the theming guide and pull out the M2 information into it's own separate guide.

This does not include updating the the theming your own components guide and the typography guide. I figured I could do that in a follow up PR to not make this too large.

@amysorto amysorto requested a review from jelbourn as a code owner May 15, 2024 15:20
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 15, 2024
@amysorto amysorto added docs This issue is related to documentation target: rc This PR is targeted for the next release-candidate labels May 15, 2024
@amysorto amysorto force-pushed the m3-docs-changes branch 3 times, most recently from 6f89f9d to bd4d25a Compare May 15, 2024 16:20
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comment around naming is addressed. Also should remember that the guides config in the docs app needs to be updated: https://github.com/angular/material.angular.io/blob/main/src/app/shared/guide-items/guide-items.ts

guides/material-2.md Outdated Show resolved Hide resolved
@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label May 16, 2024
@amysorto amysorto merged commit 3e19768 into angular:main May 16, 2024
26 checks passed
amysorto added a commit that referenced this pull request May 16, 2024
* docs: Move M2 theming information into separate guide

* docs: Use updated API prefix in M2 guide

(cherry picked from commit 3e19768)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation docs This issue is related to documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants