refactor(cdk/table): remove mixin function usages #28622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
table-sticky-mixin
branch
from
5ce0045
to
47b63d6
Compare
Removes the final usages of TypeScript mixins in the CDK table by adding the sticky functionality to the individual usages. Ideally we'd have a base class for this, but that won't be usable in `CdkHeaderRowDef` and `CdkFooterRowDef` because they already inherit from `BaseRowDef` and we can't put the sticky functionality there, because `CdkRowDef` shouldn't support `sticky`. The logic is pretty basic so I think it's fine to duplicate it.
crisbeto
force-pushed
the
table-sticky-mixin
branch
from
47b63d6
to
96d57a4
Compare
crisbeto
added
the
merge: preserve commits
angular-robot
bot
added
the
area: build & ci
Fixes that the build was throwing an error when using the object literal syntax for the `inputs` array.
crisbeto
force-pushed
the
table-sticky-mixin
branch
from
05b4e08
to
7aadde6
Compare
amysorto
approved these changes
Feb 22, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the final usages of TypeScript mixins in the CDK table by adding the sticky functionality to the individual usages. Ideally we'd have a base class for this, but that won't be usable in
CdkHeaderRowDefandCdkFooterRowDefbecause they already inherit fromBaseRowDefand we can't put the sticky functionality there, becauseCdkRowDefshouldn't supportsticky. The logic is pretty basic so I think it's fine to duplicate it.