build: ensure component owners are assigned to public API changes #28573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently everything under `/tools` is set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories in `tools` *except* the goldens to dev infra so that the owners linting can pick up any missing files. I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules.
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin and
jelbourn
as code owners
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Feb 12, 2024
crisbeto
added a commit
that referenced
this pull request
Feb 12, 2024
…8573) Currently everything under `/tools` is set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories in `tools` *except* the goldens to dev infra so that the owners linting can pick up any missing files. I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules. (cherry picked from commit 7294c6e)
crisbeto
added a commit
that referenced
this pull request
Feb 12, 2024
…8573) Currently everything under `/tools` is set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories in `tools` *except* the goldens to dev infra so that the owners linting can pick up any missing files. I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules. (cherry picked from commit 7294c6e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently everything under
/toolsis set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories intoolsexcept the goldens to dev infra so that the owners linting can pick up any missing files.I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules.