Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/list): match leading icon size in M3 to spec #28564

Closed
wants to merge 1 commit into from
Closed

fix(material/list): match leading icon size in M3 to spec #28564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/material-experimental/theming/_m3-tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,17 @@
/// @param {Map} $initial-tokens Map of list tokens currently being generated.
/// @return {Map} The given tokens, with the inconsistent values replaced with valid ones.
@function _fix-list-tokens($tokens) {
// This does not match the spec, which defines this to be `md.sys.color.surface`.
// However, this interferes with the use case of placing a list on other components. For example,
// the bottom sheet's container color is `md.sys.color.surface-container-low`. Instead, allow the
// list to just display the colors for its background.
@return map.set($tokens, list-item-container-color, transparent);
@return map.merge($tokens, (
// This does not match the spec, which defines this to be `md.sys.color.surface`. However, this
// interferes with the use case of placing a list on other components. For example, the bottom
// sheet's container color is `md.sys.color.surface-container-low`. Instead, allow the list to
// just display the colors for its background.
list-item-container-color: transparent,

// Match spec, which has list-item-leading-icon-size of 24px. Current version of tokens (0_161)
// has 18px.
list-item-leading-icon-size: 24px,
));
}

/// Generates a set of namespaced tokens for all components.
Expand Down
Loading