Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/list): ensure leading icon scales with token #28563

Closed
wants to merge 1 commit into from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 8, 2024

Correct the font size of leading icon in List component. Set font-size of leading icon to same value as its width and height. Ensure Ensure icon scales to "list-item-leading-icon-size" token.

Fix icon with cut-off appearance when "list-item-leading-icon-size" is less than 24px.

Correct the font size of leading icon in List component. Set font-size of
leading icon to same value as its width and height. Ensure Ensure icon scales to
"list-item-leading-icon-size" token.

Fix icon with cut-off appearance when "list-item-leading-icon-size" is less than
24px.
@zarend zarend added target: patch This PR is targeted for the next patch release area: material/list labels Feb 8, 2024
@zarend zarend marked this pull request as ready for review February 8, 2024 22:20
@zarend zarend added action: review The PR is still awaiting reviews from at least one requested reviewer dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Deployed dev-app for 807aec7 to: https://ng-dev-previews-comp--pr-angular-components-28563-dev-q69ea5nl.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@zarend zarend added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 8, 2024
@zarend
Copy link
Contributor Author

zarend commented Feb 13, 2024

Closing in favor of #28567

@zarend zarend closed this Feb 13, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/list dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants