Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 list #28547

Merged
merged 3 commits into from
Feb 8, 2024
Merged

M3 list #28547

merged 3 commits into from
Feb 8, 2024

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 6, 2024

No description provided.

@zarend zarend added target: minor This PR is targeted for the next minor release merge: preserve commits When the PR is merged, a rebase and merge should be performed dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Feb 6, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label Feb 6, 2024
@zarend
docs(material/list): add example of line scenarios with checkbox
a99bdd2 
Add example of line scenarios with checkbox.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

Deployed dev-app for 80d5f0d to: https://ng-dev-previews-comp--pr-angular-components-28547-dev-u0dyp3dn.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@zarend
fix(material/list): tokenize space around leading icon
a9590e5 
List component: tokenize space on left and right of leading icon.

Correct spacing around leading icon on M3. Currently, leading icon has
16px margin in front of icon and 32px behind. Give leading icon
symmetrical margin for M3.

Does not intend to make visual change to M2.
@zarend zarend marked this pull request as ready for review February 6, 2024 18:34
mmalerba
mmalerba approved these changes Feb 6, 2024
View reviewed changes
src/material/list/list.scss Outdated Show resolved Hide resolved
src/material/list/_list-theme.scss Outdated Show resolved Hide resolved
src/material/list/_list-theme.scss Show resolved Hide resolved
@zarend zarend added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 7, 2024
@zarend zarend merged commit ca5d0f1 into angular:main Feb 8, 2024
28 of 30 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/list dev-app preview When applied, previews of the dev-app are deployed to Firebase merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @mmalerba