Fixing indexOf usage bug when selection-list handles changes in items. #28531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyoo
changed the title
dyoo
force-pushed
the
select-list-b323254994
branch
2 times, most recently
from
0581edb
to
f97fef6
Compare
The buggy logic was using a truthiness check for checking for presence in a list, but this check needed to compare against -1 instead. This corrects a mismanagement of tabIndex on the items in the selection list: if the list of items changed, the selection list could not be tab selected until the selection list was mouse-focused.
dyoo
force-pushed
the
select-list-b323254994
branch
from
f97fef6
to
8e64e83
Compare
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Feb 8, 2024
…28531) The buggy logic was using a truthiness check for checking for presence in a list, but this check needed to compare against -1 instead. This corrects a mismanagement of tabIndex on the items in the selection list: if the list of items changed, the selection list could not be tab selected until the selection list was mouse-focused. (cherry picked from commit f1e82da)
crisbeto
pushed a commit
that referenced
this pull request
Feb 8, 2024
…28531) The buggy logic was using a truthiness check for checking for presence in a list, but this check needed to compare against -1 instead. This corrects a mismanagement of tabIndex on the items in the selection list: if the list of items changed, the selection list could not be tab selected until the selection list was mouse-focused. (cherry picked from commit f1e82da)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buggy logic was using a truthiness check for checking for presence in a list; this check needs to compare against -1 instead. This bug causes mismanagement of tabIndex, which caused an accessibility bug where, if the list of items changed, the selection list could not be tab selected until the selection list was focused.