Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(material/slide-toggle): m3 handle tokens #28528

Closed
wants to merge 0 commits into from

Conversation

wagnermaciel
Copy link
Contributor

  • use transform instead of width and margin

@wagnermaciel wagnermaciel marked this pull request as ready for review February 2, 2024 20:41
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but do we need to worry about RTL?

@wagnermaciel
Copy link
Contributor Author

LGTM overall, but do we need to worry about RTL?

Yep, this breaks for RTL. I'm going to sideline this PR for now because I haven't found a way to resolve this in a way that's not gross and it's not a high priority change

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants