fix(material/select): styles for m3 #28492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Feb 1, 2024
| @@ -17,6 +17,7 @@ $prefix: (mat, select); | |||
| $on-surface: if($is-dark, #fff, #000); | |||
|
|
|||
| @return ( | |||
| list-item-selected-container-color: rgba($on-surface, if($is-dark, 0.08, 0.04)), | |||
There was a problem hiding this comment.
The option already has a selected-state-layer-color token for this. Also I think the option selected state is correct atm, we were discussing this yesterday with @mmalerba
There was a problem hiding this comment.
Are we certain the option selected state color is correct? This is what the background-color looks like without this override:
And this is what it looks like with it:
wagnermaciel
force-pushed
the
m3-select
branch
2 times, most recently
from
a0ea74a to
927fdea
Compare
wagnermaciel
force-pushed
the
m3-select
branch
from
927fdea to
24b9c15
Compare
crisbeto
approved these changes
Feb 2, 2024
wagnermaciel
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.