Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/paginator): match visual and reading order #28285

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Dec 14, 2023

Fix accessibility issue in MatPaginator component. When screen is narrow, maintain the visual order with the DOM order.

Current behavior is swappign visual order of "Items Per Page" and "1 of 4" on narrow screens. With this commit applied, no longer swap the order.

Fix accessibility issue in MatPaginator component. When screen is
narrow, maintain the visual order with the DOM order.

Current behavior is swappign visual order of "Items Per Page" and
"1 of 4" on narrow screens. With this commit applied, no longer swap the
order.
@zarend zarend added Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/paginator labels Dec 14, 2023
@zarend
Copy link
Contributor Author

zarend commented Dec 14, 2023

Googlers: internal tests have passed.

@zarend zarend added the target: minor This PR is targeted for the next minor release label Dec 14, 2023
@zarend
Copy link
Contributor Author

zarend commented Dec 14, 2023

This PR is forked from #28046. No code has been changed from #28046. Only the commit message has changed.

@zarend zarend added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 14, 2023
@zarend zarend merged commit 4d0719a into angular:main Dec 14, 2023
31 of 33 checks passed
essjay05 pushed a commit to essjay05/angular-components that referenced this pull request Dec 14, 2023
Fix accessibility issue in MatPaginator component. When screen is
narrow, maintain the visual order with the DOM order.

Current behavior is swappign visual order of "Items Per Page" and
"1 of 4" on narrow screens. With this commit applied, no longer swap the
order.

Co-authored-by: DBowen33 <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/paginator merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants