YouTube player features #28171
Merged
YouTube player features #28171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds input coercion support to the `youtube-player` component. Previously we couldn't do it because we didn't want to introduce a dependency to `@angular/cdk`.
crisbeto
added
P3
crisbeto
force-pushed
the
youtube-player-load
branch
2 times, most recently
from
0545e93
to
737ab03
Compare
crisbeto
commented
Nov 22, 2023
| }; | ||
| script.addEventListener('load', callback); | ||
| script.addEventListener('error', callback); | ||
| (script as any).src = url; |
There was a problem hiding this comment.
The as any here is to keep the security test happy. This isn't an XSS risk since we always load https://www.youtube.com/iframe_api.
devversion
approved these changes
Nov 22, 2023
Currently users have to load the YouTube API themselves which can be tricky to get right and be prone to race conditions. Since there's only one way to load it, these changes switch to doing so automatically. Loading the API automatically also enables us to optimize the component further in a follow-up PR by showing a placeholder image. If users don't want the API to be loaded automatically, they can disable it through an input or using the newly-introduced `YOUTUBE_PLAYER_CONFIG` injection token. Fixes angular#17037.
crisbeto
force-pushed
the
youtube-player-load
branch
from
737ab03
to
2b4c7cc
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following new features for the YouTube player component:
feat(youtube-player): coerce inputs
Adds input coercion support to the
youtube-playercomponent. Previously we couldn't do it because we didn't want to introduce a dependency to@angular/cdk.feat(youtube-player): automatically load youtube api
Currently users have to load the YouTube API themselves which can be tricky to get right and be prone to race conditions. Since there's only one way to load it, these changes switch to doing so automatically. Loading the API automatically also enables us to optimize the component further in a follow-up PR by showing a placeholder image.
If users don't want the API to be loaded automatically, they can disable it through an input or using the newly-introduced
YOUTUBE_PLAYER_CONFIGinjection token.Fixes #17037.
Note: there was an earlier attempt at this feature in #21401 which didn't land due to some concerns around API loading. We've discussed this with @jelbourn and agreed that they're no longer a problem.